Security: Raw exception messages are returned to clients in throttling middleware#3296
Open
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Open
Conversation
In `afterException`, the middleware returns `$exception->getMessage()` to the client for `NoSuchFormException`. If exception messages include internal identifiers, query context, or untrusted input, this can lead to information disclosure and potentially reflected content issues in consuming clients. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Raw exception messages are returned to clients in throttling middleware
Problem
Severity:
Medium| File:lib/Middleware/ThrottleFormAccessMiddleware.php:L21In
afterException, the middleware returns$exception->getMessage()to the client forNoSuchFormException. If exception messages include internal identifiers, query context, or untrusted input, this can lead to information disclosure and potentially reflected content issues in consuming clients.Solution
Return a fixed, generic error message (e.g., 'Form not found') and log detailed exception context server-side only.
Changes
lib/Middleware/ThrottleFormAccessMiddleware.php(modified)